Hooks: Update deny_binary to correctly handle pushes to new repos

Before, the hook would allow pushing binary files to newly created empty
repos. Now we handle and test this in our test suite.

hooks/deny_binary

@@ -28,9 +28,17 @@ while read oldrev newrev refname; do
     continue
   fi
 
-  # Set oldrev to HEAD if this is branch creation.
   if [ "$oldrev" = "$nullsha" ]; then
-    oldrev="HEAD"
+    if [ $(git rev-parse HEAD) = "HEAD" ]; then
+      # Iterate over all commits if there is no HEAD.
+      # This happens when the repo has just been initalized
+      rev_range=${newrev}
+    else
+      # Don't iterate over any commits already in the default branch of the repo
+      rev_range=HEAD..${newrev}
+    fi
+  else
+    rev_range=${oldrev}..${newrev}
   fi
 
   # Check for branches and tags, but not pull requests in refs/pull. Otherwise Gitea
@@ -44,7 +52,7 @@ while read oldrev newrev refname; do
   fi
 
   # Loop over each commit.
-  for commit in $(git rev-list --objects ${oldrev}..${newrev} |
+  for commit in $(git rev-list --objects ${rev_range} |
     git cat-file --batch-check='%(objectname) %(objecttype) %(objectsize) %(rest)' | grep commit | awk '{print $1}'); do
 
     # Get list of potentially binary files in this commit

hooks/test/deny_binary/20_initial_binary_file_test.sh

@@ -2,9 +2,7 @@
 
 # Test: Add binary file to an empty repository and try to push.
 #
-# It is expected to pass as part of a logic which allows to branch off
+# It should fail as we should block binary files from be pushed.
-# existing branches where it is possible to have binary files that were
-# added prior to migration to Git LFS.
 
 set -e
 
@@ -23,7 +21,7 @@ install_hook "${ORIGIN_REPO_DIR}" "${SCRIPT_PATH}/../../deny_binary" "pre-receiv
 dd if=/dev/zero of="${WORK_GIT_DIR}/data.bin" bs=1 count=32k
 git -C "${WORK_GIT_DIR}" add data.bin
 git -C "${WORK_GIT_DIR}" commit --message "Initial commit"
-if ! git -C "${WORK_GIT_DIR}" push; then
+if git -C "${WORK_GIT_DIR}" push; then
   exit 1
 fi
 

hooks/test/deny_binary/23_force_add_binary_file_test.sh

@@ -0,0 +1,29 @@
+#!/bin/sh
+
+# Test: Add binary file to an empty repository and push it by bypassing the hook.
+#
+
+set -e
+
+SCRIPT=$(readlink -f "$0")
+SCRIPT_PATH=$(dirname "$SCRIPT")
+
+. ${SCRIPT_PATH}/functions
+
+setup_temp_git_identity
+
+ORIGIN_REPO_DIR=`setup_bare_origin_repository`
+WORK_GIT_DIR=`clone_repository "${ORIGIN_REPO_DIR}"`
+
+install_hook "${ORIGIN_REPO_DIR}" "${SCRIPT_PATH}/../../deny_binary" "pre-receive"
+
+dd if=/dev/zero of="${WORK_GIT_DIR}/data.bin" bs=1 count=32k
+git -C "${WORK_GIT_DIR}" add data.bin
+git -C "${WORK_GIT_DIR}" commit --message "Initial commit, override restrictions"
+if ! git -C "${WORK_GIT_DIR}" push; then
+  exit 1
+fi
+
+echo
+echo "Test passed!"
+exit 0

hooks/test/deny_binary/40_add_binary_file_and_convert_test.sh

@@ -36,8 +36,6 @@ git -C "${WORK_GIT_DIR}" lfs track "*.bin"
 git -C "${WORK_GIT_DIR}" add .gitattributes
 git -C "${WORK_GIT_DIR}" commit --message "Track .bin files with Git LFS"
 
-git -C "${WORK_GIT_DIR}" lfs migrate import --no-rewrite --yes data.bin
-
 if git -C "${WORK_GIT_DIR}" push; then
   exit 1
 fi

hooks/test/deny_binary/52_branch_legacy_file_iteration_test.sh

@@ -0,0 +1,50 @@
+#!/bin/sh
+
+# Test: Ensure that we don't iterate over legacy files when branching
+#
+# Ensure that we don't iterate over legacy commits when pushing new branches
+
+set -e
+
+SCRIPT=$(readlink -f "$0")
+SCRIPT_PATH=$(dirname "$SCRIPT")
+
+. ${SCRIPT_PATH}/functions
+
+setup_temp_git_identity
+
+ORIGIN_REPO_DIR=`setup_bare_origin_repository`
+WORK_GIT_DIR=`clone_repository "${ORIGIN_REPO_DIR}"`
+
+dd if=/dev/zero of="${WORK_GIT_DIR}/data.bin" bs=1 count=32k
+git -C "${WORK_GIT_DIR}" add data.bin
+git -C "${WORK_GIT_DIR}" commit --message "Initial commit"
+if ! git -C "${WORK_GIT_DIR}" push; then
+  exit 1
+fi
+
+install_hook "${ORIGIN_REPO_DIR}" "${SCRIPT_PATH}/../../deny_binary" "pre-receive"
+
+git -C "${WORK_GIT_DIR}" lfs install
+git -C "${WORK_GIT_DIR}" lfs track "*.bin"
+git -C "${WORK_GIT_DIR}" add .gitattributes
+touch "${WORK_GIT_DIR}/data.bin"
+git -C "${WORK_GIT_DIR}" commit --message "Track .bin files with Git LFS"
+
+if ! git -C "${WORK_GIT_DIR}" push; then
+  exit 1
+fi
+
+git -C "${WORK_GIT_DIR}"  branch new_branch
+git -C "${WORK_GIT_DIR}"  switch new_branch
+touch "${WORK_GIT_DIR}/text_file"
+git -C "${WORK_GIT_DIR}" add text_file
+git -C "${WORK_GIT_DIR}" commit --message "Add regular text file"
+
+if ! git -C "${WORK_GIT_DIR}" push --set-upstream origin new_branch; then
+  exit 1
+fi
+
+echo
+echo "Test passed!"
+exit 0